Remove 'view' implementation. #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SubArray works fine on GPU, and the existing override broke 'view(x, :)' due to nonexisting '.start'.
maleadt
added
bugfix
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 80.54% 80.54%
=======================================
Files 166 166
Lines 8852 8852
=======================================
Hits 7130 7130
Misses 1722 1722 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubArray works fine on GPU, and the existing override broke 'view(x, :)' due to nonexisting '.start'.
Fixes https://discourse.julialang.org/t/error-when-calling-2d-dynamic-kernel-with-view-argument/47647