-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert array wrapper union changes #498
Conversation
Thanks! Using |
Using |
I see. Hope the load time can be optimized later. Just add an example to the issue in #494
In a tensor package, reshaping happens quite often. It will be easier to handle if the array type is not changed. |
Right, but is that an issue? Your package should probably handle julia> reinterpret(Float64, zeros(4,4)) |> typeof
Base.ReinterpretArray{Float64,2,Float64,Array{Float64,2}} |
Hmm, you are right. It is more likely a matter of fixing legacy code. |
This includes reinterpret, reshape, and contiguous views.
ebd875d
to
ec433ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 80.45% 80.54% +0.09%
==========================================
Files 166 166
Lines 8822 8879 +57
==========================================
+ Hits 7098 7152 +54
- Misses 1724 1727 +3
Continue to review full report at Codecov.
|
Too costly, latency wise.