Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reshape with missing dimensions. #512

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Fix reshape with missing dimensions. #512

merged 1 commit into from
Oct 28, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 26, 2020

Fixes #511

@maleadt maleadt added cuda array Stuff about CuArray. bugfix This gets something working again. labels Oct 26, 2020
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #512 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #512   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files         166      166           
  Lines        8878     8879    +1     
=======================================
+ Hits         7150     7151    +1     
  Misses       1728     1728           
Impacted Files Coverage Δ
test/array.jl 0.00% <ø> (ø)
src/array.jl 89.30% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025f286...feb145d. Read the comment docs.

@maleadt maleadt merged commit 2330069 into master Oct 28, 2020
@maleadt maleadt deleted the tb/reshape_colon branch October 28, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda array Stuff about CuArray.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reshaped CuArray is not DenseCuArray
1 participant