Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit_diag option for sv2! functions #540

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Nov 12, 2020

ilu02 function returns a matrix composed of a lower triangular and a unit upper triangular factor. I updated sv2! to work with unit triangular matrices.
Should I use unit_diag as an argument with default value false or keep it as a keyword argument?

I also found that istril has missing methods (JuliaLang/julia#38404), I updated the code to avoid scalar operations.

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #540 (2d7180f) into master (e09bf71) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   77.83%   77.82%   -0.01%     
==========================================
  Files         116      116              
  Lines        6415     6423       +8     
==========================================
+ Hits         4993     4999       +6     
- Misses       1422     1424       +2     
Impacted Files Coverage Δ
lib/cusparse/interfaces.jl 37.14% <66.66%> (+3.80%) ⬆️
lib/cusparse/level2.jl 83.14% <78.57%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09bf71...2d7180f. Read the comment docs.

@maleadt maleadt added cuda array Stuff about CuArray. enhancement New feature or request labels Nov 12, 2020
@maleadt
Copy link
Member

maleadt commented Nov 12, 2020

Thanks!
A keyword argument seems fine; this is an internal wrapper anyway, so we can always update it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda array Stuff about CuArray. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants