Add lock around cfunction lookup
#589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
commented
Dec 5, 2020
vchuravy
commented
Dec 6, 2020
vchuravy
commented
Dec 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
=======================================
Coverage 79.94% 79.94%
=======================================
Files 116 116
Lines 6870 6872 +2
=======================================
+ Hits 5492 5494 +2
Misses 1378 1378
Continue to review full report at Codecov.
|
maleadt
approved these changes
Dec 7, 2020
|
Maybe add an inline comment pointing to the issue? Otherwise we'll never delete that lock. |
vchuravy
commented
Dec 7, 2020
Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
maleadt
pushed a commit
that referenced
this pull request
Jan 5, 2021
maleadt
pushed a commit
that referenced
this pull request
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around JuliaLang/julia#38709 and fixes #588