Re-initialize the random seed every time. #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out we can't rely on the shared memory persisting across launches, so we need to initialize the key at every launch. That also implies we need a fresh seed for every launch, because otherwise two subsequent launches would generate the same numbers. To avoid having to upload a seed before every launch, use the `clock` register as a source of randomness to initialize the key with.
maleadt
added
bugfix
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
==========================================
+ Coverage 76.85% 76.87% +0.01%
==========================================
Files 121 121
Lines 7709 7705 -4
==========================================
- Hits 5925 5923 -2
+ Misses 1784 1782 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we can't rely on the shared memory persisting across launches,
so we need to initialize the key at every launch. That also implies we
need a fresh seed for every launch, because otherwise two subsequent
launches would generate the same numbers. To avoid having to upload a
seed before every launch, use the
clockregister as a source ofrandomness to initialize the key with.
Should fix the sporadic failures seed on CI.