Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't initialize the API when setting log callbacks. #992

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jun 17, 2021

As spotted in #978

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #992 (8ddd314) into master (c77e985) will decrease coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
- Coverage   78.75%   78.14%   -0.62%     
==========================================
  Files         122      122              
  Lines        7918     7970      +52     
==========================================
- Hits         6236     6228       -8     
- Misses       1682     1742      +60     
Impacted Files Coverage Δ
lib/cusolver/error.jl 30.76% <0.00%> (-53.85%) ⬇️
src/broadcast.jl 75.00% <0.00%> (-10.72%) ⬇️
lib/cudnn/dropout.jl 90.32% <0.00%> (-9.68%) ⬇️
lib/cublas/util.jl 82.22% <0.00%> (-8.03%) ⬇️
lib/cusolver/base.jl 55.55% <0.00%> (-6.95%) ⬇️
lib/cudnn/softmax.jl 69.23% <0.00%> (-5.77%) ⬇️
lib/cudnn/activation.jl 71.42% <0.00%> (-5.50%) ⬇️
lib/cusolver/CUSOLVER.jl 78.00% <0.00%> (-5.34%) ⬇️
lib/cudnn/optensor.jl 76.47% <0.00%> (-4.78%) ⬇️
lib/cudnn/reduce.jl 63.33% <0.00%> (-4.53%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77e985...8ddd314. Read the comment docs.

@maleadt maleadt merged commit 34545e8 into master Jun 17, 2021
@maleadt maleadt deleted the tb/log_init branch June 17, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant