Generalize classify arguments function

JuliaGPU · Feb 6, 2022 · 31636cb · 31636cb
1 parent 6d8d62b
commit 31636cb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/interface.jl b/src/interface.jl
@@ -182,7 +182,8 @@ function process_entry!(@nospecialize(job::CompilerJob), mod::LLVM.Module,
     if job.source.kernel
         # pass all bitstypes by value; by default Julia passes aggregates by reference
         # (this improves performance, and is mandated by certain back-ends like SPIR-V).
-        args = classify_arguments(job, eltype(llvmtype(entry)))
+        source_sig = Base.signature_type(job.source.f, job.source.tt)::Type
+        args = classify_arguments(source_sig, eltype(llvmtype(entry)))
         for arg in args
             if arg.cc == BITS_REF
                 attr = if LLVM.version() >= v"12"

diff --git a/src/irgen.jl b/src/irgen.jl
@@ -287,10 +287,8 @@ end
     GHOST       # not passed
 end
 
-function classify_arguments(@nospecialize(job::CompilerJob), codegen_ft::LLVM.FunctionType)
-    source_sig = Base.signature_type(job.source.f, job.source.tt)::Type
+function classify_arguments(source_sig::Type, codegen_ft::LLVM.FunctionType)
     source_types = [source_sig.parameters...]
-
     codegen_types = parameters(codegen_ft)
 
     args = []

diff --git a/src/spirv.jl b/src/spirv.jl
@@ -239,7 +239,8 @@ function wrap_byval(@nospecialize(job::CompilerJob), mod::LLVM.Module, f::LLVM.F
         else
             ft
         end
-        args = classify_arguments(job, orig_ft)
+        source_sig = Base.signature_type(job.source.f, job.source.tt)::Type
+        args = classify_arguments(source_sig, entry_f)
         filter!(args) do arg
             arg.cc != GHOST
         end