Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to upstream changes to return_types #312

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

aviatesk
Copy link
Contributor

@aviatesk aviatesk commented Mar 15, 2022

Fixes #309

Still we want to wait for the release of next beta version and change the version compat accordingly.

@maleadt
Copy link
Member

maleadt commented Mar 15, 2022

Still we want to wait for the release of next beta version and change the version compat accordingly.

That will just be v"1.8.0-beta2", right?

@maleadt maleadt changed the title update with https://github.com/JuliaLang/julia/pull/44515 Adapt to upstream changes to return_types Mar 15, 2022
@aviatesk
Copy link
Contributor Author

That will just be v"1.8.0-beta2", right?

yep, done!

src/validation.jl Outdated Show resolved Hide resolved
aviatesk and others added 2 commits March 16, 2022 08:36
Especially this commits adds the update corresponding to 
<JuliaLang/julia#44515>.
@maleadt
Copy link
Member

maleadt commented Mar 16, 2022

Tested this on 1.8-beta2 (current release-1.8), and now overrides are back to being broken 😢

overrides: Test Failed at /home/tim/Julia/pkg/GPUCompiler/test/native.jl:387
  Expression: occursin("ret i64 1", ir)
   Evaluated: occursin("ret i64 1", ";  @ /home/tim/Julia/pkg/GPUCompiler/test/native.jl:380 within `kernel`\n; Function Attrs: alwaysinline\ndefine i64 @julia_kernel_4321() local_unnamed_addr #0 {\ntop:\n  ret i64 0\n}\n")

Specifically, the reproducer from JuliaLang/julia#44174 fails again (it didn't on beta1, but constant propagation was pretty much disabled with overlayed method tables there).

@aviatesk
Copy link
Contributor Author

Hmm... I will look into it.

@aviatesk
Copy link
Contributor Author

Specifically, the reproducer from JuliaLang/julia#44174 fails again (it didn't on beta1, but constant propagation was pretty much disabled with overlayed method tables there).

I confirmed that should work now. Basically I forgot that I backported JuliaLang/julia#44389 also.

@maleadt
Copy link
Member

maleadt commented Mar 16, 2022

Works great, thanks!

@maleadt maleadt merged commit 8dba144 into JuliaGPU:master Mar 16, 2022
@aviatesk aviatesk deleted the avi/update branch March 16, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.8 regression: isbitstype does not resolve at compile-time
2 participants