Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A wrong function name parallellise #177

Closed
ArrogantGao opened this issue Nov 20, 2023 · 1 comment · Fixed by #178
Closed

A wrong function name parallellise #177

ArrogantGao opened this issue Nov 20, 2023 · 1 comment · Fixed by #178

Comments

@ArrogantGao
Copy link

I notice that there is a function parallellise in tiling.jl, while it is called parallelise in the article, I suppose that it is a typo?
I also wonder will you release the latest code as a new version recently? The current released 0.1.0 can not work with Julia after v1.8, and I am trying to build some new packaged based on that.
thomasfaingnaert added a commit that referenced this issue Nov 20, 2023
@thomasfaingnaert
Fix typo in parallelise function name
d29a133 
Fixes #177
@thomasfaingnaert thomasfaingnaert mentioned this issue Nov 20, 2023
Merged
@thomasfaingnaert
Copy link
Member

I notice that there is a function parallellise in tiling.jl, while it is called parallelise in the article, I suppose that it is a typo?

Yes, that's indeed a typo. Thanks for mentioning that! Should be fixed by #178.

I also wonder will you release the latest code as a new version recently? The current released 0.1.0 can not work with Julia after v1.8, and I am trying to build some new packaged based on that.

You can also add GemmKernels@master, but we should release a new version, indeed. Probably when we finish our work on tensor contractions, @maleadt?

thomasfaingnaert added a commit that referenced this issue Nov 21, 2023
@thomasfaingnaert
Fix typo in parallelise function name (#178)
8207701 
Fixes #177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in parallelise function name JuliaGPU/GemmKernels.jl
2 participants
@thomasfaingnaert @ArrogantGao