Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of FPU operator in BLAS wrappers. #113

Merged
merged 5 commits into from
Jul 4, 2023
Merged

Enable use of FPU operator in BLAS wrappers. #113

merged 5 commits into from
Jul 4, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jun 27, 2023

No description provided.

src/blas.jl Outdated Show resolved Hide resolved
@maleadt
Copy link
Member Author

maleadt commented Jun 29, 2023

Benchmark results for commit b50b370 (comparing to c4fdd23):
No regressions or improvements detected.

@maleadt maleadt force-pushed the tb/fpu_blas branch 2 times, most recently from 4a319f2 to c2ae546 Compare June 29, 2023 15:31
@maleadt
Copy link
Member Author

maleadt commented Jun 29, 2023

Well, that's quite a significant speed-up! I wonder if that's due to the Zero layout. I should probably split that off to be sure.

@maleadt
Copy link
Member Author

maleadt commented Jun 30, 2023

Well, it's surprising that this still yields a speed-up. Maybe the conversion of alpha and beta to the compute type?

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.43 🎉

Comparison is base (d347375) 30.23% compared to head (b50b370) 30.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   30.23%   30.67%   +0.43%     
==========================================
  Files          11       11              
  Lines         797      802       +5     
==========================================
+ Hits          241      246       +5     
  Misses        556      556              
Impacted Files Coverage Δ
src/blas.jl 86.84% <100.00%> (+1.99%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt marked this pull request as ready for review July 4, 2023 09:33
@maleadt maleadt merged commit 033da06 into master Jul 4, 2023
@maleadt maleadt deleted the tb/fpu_blas branch July 4, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants