Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@test
+≈
for automaticisapprox
mul!
directly in order to perform a mixed-mode multiplication on the CPU tooThat last point slows down the tests a bit, but I think it's a better comparison. @thomasfaingnaert, was there a reason you compared against multiplications that were done in the output type instead of the input type? Maybe we should just scale down the very big (2048x2048x2048) tests.