-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add layouts for accessing unaligned or non tile-sized global. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use it to extend the BLAS API to all input sizes.
Benchmark results for commit 3fafafc (comparing to 033da06):
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 30.67% 31.20% +0.52%
==========================================
Files 11 11
Lines 802 875 +73
==========================================
+ Hits 246 273 +27
- Misses 556 602 +46
☔ View full report in Codecov by Sentry. |
The slowdown is entirely spent on the host. Let's add a simple cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step towards making the BLAS API more generally usable.
Performance is worse, of course. We could try to do better, e.g. doing vectorized loads for most of the input, but that becomes complicated quickly so let's do the simple thing first.
4096 x 4096
4095 x 4095
The code looks pretty bad, with LLVM not predicating the element-wise loads/stores but inserting loads of branches:
I guess LLVM lacks a good if conversion? In any case, because the pattern is so clear,
ptxas
does detect it and generate predicated SASS:Fixes #52