Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect alignment issues and throw a Julia error. #134

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jul 6, 2023

Only happens with --check-bounds=yes, but is much easier to detect (ERROR_MISALIGNED is fatal and requires re-starting the process).

@maleadt
Copy link
Member Author

maleadt commented Jul 6, 2023

Benchmark results for commit 0a9d89e (comparing to ae8cbfe):

ID mean₁ mean₂ Δmin
["BLAS", "WMMA", "Float16*Float16'=Float32 (4096×4096×4096, alpha)"] 6.073 ms ± 2.324 μs 5.676 ms ± 644.579 μs 27.2% ✅

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.29 ⚠️

Comparison is base (ae8cbfe) 31.28% compared to head (0a9d89e) 31.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   31.28%   31.00%   -0.29%     
==========================================
  Files          10       10              
  Lines         879      887       +8     
==========================================
  Hits          275      275              
- Misses        604      612       +8     
Impacted Files Coverage Δ
src/layout.jl 16.16% <0.00%> (-0.69%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit c4ae038 into master Jul 6, 2023
@maleadt maleadt deleted the tb/alignment_error branch July 6, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant