Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw ConfigError for unsupported WMMA shapes #166

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

thomasfaingnaert
Copy link
Member

No description provided.

@maleadt
Copy link
Member

maleadt commented Oct 27, 2023

Benchmark results for commit 3ed9d8b (comparing to e78e1e7):

test master PR Δmin
FPU GEMM Float64*Float64=Float64 (128×128) · (128×128) (NN) OP (8, 16, 2), base shape (4, 8, 1) 147.0 μs ± 2.56% (130.0 … 149.0 μs) 148.0 μs ± 0.12% (148.0 … 149.0 μs) +13.8% ❌
WMMA GEMM+bias Float16*Float16+Float32=Float32 (4096×4096) · (4096×4096) (TN) OP (16, 16, 16) 2.5 ms ± 1.87% (2.44 … 2.72 ms) 2.61 ms ± 1.6% (2.58 … 2.82 ms) +5.6% ❌
WMMA Complex GEMM Float16*Float16=Float32 (128×128) · (128×128) (NT) OP (16, 16, 16) 8.42 μs ± 1.88% (8.11 … 8.82 μs) 9.57 μs ± 1.59% (9.3 … 9.78 μs) +14.7% ❌
FPU GEMM Float32*Float32=Float64 (128×128) · (128×128) (NN) OP (8, 16, 2), base shape (4, 8, 1) 174.0 μs ± 3.21% (167.0 … 181.0 μs) 180.0 μs ± 0.315% (179.0 … 180.0 μs) +6.8% ❌
WMMA GEMM Float16*Float16=Float16 (2048×2048) · (2048×2048) (NT) OP (16, 16, 16) 295.0 μs ± 0.66% (290.0 … 302.0 μs) 274.0 μs ± 6.27% (255.0 … 299.0 μs) -12.2% ✅

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e78e1e7) 33.29% compared to head (3ed9d8b) 33.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   33.29%   33.58%   +0.29%     
==========================================
  Files          11       11              
  Lines         907      914       +7     
==========================================
+ Hits          302      307       +5     
- Misses        605      607       +2     
Files Coverage Δ
src/config.jl 86.84% <85.71%> (-1.57%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 9b0585b into master Oct 27, 2023
1 check passed
@maleadt maleadt deleted the tf/config-error-wmma branch October 27, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants