-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve heuristic for memcopy tile sizes #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasfaingnaert
force-pushed
the
tf/fix-memory-heuristic
branch
from
November 14, 2023 16:04
5b2071f
to
57ee67e
Compare
Benchmark results for commit 57ee67e (comparing to 8a73476):
Comparison with baseline
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 33.58% 34.02% +0.43%
==========================================
Files 11 11
Lines 914 920 +6
==========================================
+ Hits 307 313 +6
Misses 607 607 ☔ View full report in Codecov by Sentry. |
thomasfaingnaert
changed the title
Fix occasional incorrect default value for memory
Improve heuristic for memcopy tile sizes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
By default, e.g.
mem_a_thread
is 8 FP16 elements per thread (to get 16 bytes per memory instruction), but this means that each warp handles 32 * 8 = 256 elements per iteration, or 256 * 4 * 2 = 2048 elements for all 8 warps. However, there are only BLOCK_M * BLOCK_K = 1024 elements in a CTA tile, soa_frag_i
is0
.This PR fixes this case by providing a better default, and additionally checking whether there is at least one iteration and throwing a
ConfigError
if there is not.