-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get benchmarks working again #186
Conversation
Hmm, this is unfortunate. It's only there for the validation, right? Can't we do something lazy, like https://github.com/JuliaGPU/GPUCompiler.jl/blob/962b84ed84cffc268ce1c28b1c71037566622f24/src/reflection.jl#L60-L62 ? |
It's only in the |
Ah, I missed that. Carry on. |
Benchmarks bump into an illegal memory access now, which is weird, because the configuration where it happens should also be run in CI, and it's fine there:
|
Benchmarks don't run with |
acc8945
to
8eaae54
Compare
8eaae54
to
cc229d5
Compare
I can only reproduce the illegal memory access locally on 1.9, seems to be fixed in 1.10. Let's bump benchmarks to Julia 1.10 and see if that fixes things. |
cc229d5
to
f749579
Compare
@maleadt Expired GH token?
EDIT: Nevermind, I missed the error message: Body is too long. |
Let's just merge this for now so we at least have some form of benchmarking. I'll keep track of the remaining problems in an issue. |
No description provided.