Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for FP16 multiplication #27

Merged
merged 5 commits into from
Aug 17, 2020
Merged

Conversation

thomasfaingnaert
Copy link
Member

No description provided.

@thomasfaingnaert thomasfaingnaert marked this pull request as draft August 14, 2020 13:13
This reverts commit 68244e4.
This avoids the conversions to FP32, which slow down the kernel.
@thomasfaingnaert thomasfaingnaert marked this pull request as ready for review August 17, 2020 11:34
@thomasfaingnaert thomasfaingnaert merged commit 2b94068 into master Aug 17, 2020
@thomasfaingnaert thomasfaingnaert deleted the fix-fp16-mul branch August 17, 2020 12:03
maleadt added a commit that referenced this pull request Jan 28, 2021
maleadt added a commit that referenced this pull request Feb 2, 2021
maleadt added a commit that referenced this pull request Feb 2, 2021
* Use native Float16 multiplication.

* Revert "Add workaround for FP16 multiplication (#27)"

* Don't cast to Float32 for vectorization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant