update CUDA compat #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=======================================
Coverage 41.25% 41.25%
=======================================
Files 10 10
Lines 446 446
=======================================
Hits 184 184
Misses 262 262 Continue to review full report at Codecov.
|
maleadt
requested changes
Nov 15, 2021
in a previous commit (merge JuliaGPU#82), dynamic allocation of shared memory was changed from the deprecated `@cuDynamicSharedMem` macro to the replacing `CuDynamicSharedArray` function, this breaks compatability with CUDA.jl versions before v3.5.0 as the `CuDynamicSharedArray` function was only added in CUDA.jl v3.5.
maleadt
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent commit (merge #82), dynamic allocation of shared memory was changed from the deprecated
@cuDynamicSharedMemmacro to the replacingCuDynamicSharedArrayfunction,this breaks compatability with CUDA.jl versions before v3.5.0 as the
CuDynamicSharedArrayfunction was only added in CUDA.jl v3.5.