Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneMKL] Interface lapack routines #376

Merged
merged 3 commits into from
Mar 31, 2024
Merged

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Oct 18, 2023

@kballeda @pengtu
I wrapped additional LAPACK routines but I have some errors during the compilation.
Do you also have this issue?

Update: The culprit was my local Intel compiler v2023.2.0 that was used. I'm able to compile with the compile installed by Conda.

@amontoison amontoison force-pushed the lapack branch 2 times, most recently from b84d61c to a1db608 Compare October 18, 2023 21:18
@amontoison
Copy link
Member Author

@kballeda I added more LAPACK routines and updated support.toml for the wrappers of your PR #348.

@kballeda
Copy link
Contributor

kballeda commented Oct 19, 2023

@kballeda I added more LAPACK routines and updated support.toml for the wrappers of your PR #348.

@amontoison Thanks for adding ormqr, unmqr, orgqr, ungqr primitives to the list. It's good to have tests for these primitives in test/onemkl.jl.

@amontoison
Copy link
Member Author

I will add some tests asap. What can we do to fix CI?

@kballeda
Copy link
Contributor

I will add some tests asap. What can we do to fix CI?

@amontoison #357 - Discussion on this topic

@amontoison amontoison force-pushed the lapack branch 2 times, most recently from 094de4d to 8653559 Compare October 30, 2023 17:03
@amontoison amontoison force-pushed the lapack branch 5 times, most recently from 41ae1c0 to 4c37bc7 Compare February 29, 2024 04:40
@amontoison
Copy link
Member Author

@pengtu @kballeda
I have a segmentation fault when I try to call a LAPACK routine like getrf!.
Do you have an idea of what is the issue?
Do I allocate and use correctly the buffer?

lib/mkl/wrappers_lapack.jl Outdated Show resolved Hide resolved
@amontoison amontoison changed the title Interface LAPACK routines Update the Julia interface of oneMKL Mar 5, 2024
@amontoison amontoison force-pushed the lapack branch 3 times, most recently from 232cfc6 to dba535a Compare March 20, 2024 02:53
@amontoison amontoison changed the title Update the Julia interface of oneMKL [oneMKL] Interface lapack routines Mar 20, 2024
@maleadt
Copy link
Member

maleadt commented Mar 21, 2024

I added you to the oneAPI.jl team; feel free to merge whenever this is ready and passes CI.

@maleadt maleadt added enhancement New feature or request libraries Things about libraries and how we use them. labels Mar 21, 2024
@amontoison
Copy link
Member Author

I added you to the oneAPI.jl team; feel free to merge whenever this is ready and passes CI.

Thanks @maleadt!

@amontoison amontoison force-pushed the lapack branch 2 times, most recently from 0e62342 to 678a394 Compare March 21, 2024 16:01
@amontoison amontoison merged commit 9531fc0 into JuliaGPU:master Mar 31, 2024
1 check passed
@amontoison amontoison deleted the lapack branch March 31, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request libraries Things about libraries and how we use them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants