-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SqExponential and GammaExponential + style #158
Conversation
Drop in coverage appears to be to do with style-related changes inflating the line count slightly. |
Co-authored-by: Théo Galy-Fajou <theo.galyfajou@gmail.com>
Looks like Gabor fails randomly... |
That's a bit sad. I'm reluctant to break the build, because that's really no fun for development. Have we got work ongoing to fix Gabor + AD? |
It seems to be fine apart from the tests with Julia nightlies, doesn't it? I assume the test errors there are caused by some Zygote and compiler-related issues that we do not have to worry about (at least I know that these Zygote/compiler problems cause test errors of Turing with Julia nightly quite consistently). Maybe best to just allow test failures on Julia nightly? |
Oh, weird. It was failing on version 1 before. I guess someone re-ran the builds? Assuming that docs pass then this is good to go. |
Yeah I reran the failing build |
* Update docstring corresponding to #158 * LGTM style fix Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk> * bump the patch version * Update src/basekernels/exponential.jl Co-authored-by: David Widmann <devmotion@users.noreply.github.com> Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk> Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Our implementations of the mentioned kernels were quite non-standard, so I've brought them inline with what is usually used.
I've also fixed some style issues. Apologies for conflating the two in a single PR.
The only changes of importance are those in
src/exponential.jl
-- everything else is either style or modifying tests to respect the new convention.