Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test GDAL 3.7.2 #161

Merged
merged 1 commit into from
Sep 22, 2023
Merged

test GDAL 3.7.2 #161

merged 1 commit into from
Sep 22, 2023

Conversation

visr
Copy link
Member

@visr visr commented Sep 22, 2023

This in turn allows GDAL 3.7.2, which requires PROJ_jll v901 (which is PROJ 9.3).

I want to see about downstream failures.

This in turn allows GDAL 3.7.2, which requires PROJ_jll v901 (which is PROJ 9.3).

I want to see about downstream failures.
@visr
Copy link
Member Author

visr commented Sep 22, 2023

Some breakage on ArchGDAL, and the Rasters downstream test is failing because Rasters doesn't have GDAL as a direct dependency and therefor no compat set? @rafaqz this should be possible right? Otherwise, I guess it's also not terrible to add GDAL as a direct dependency as well.

Rasters [a3a2b9e3-a471-40c9-b274-f788e487c689]: Test Failed at /home/runner/.julia/packages/Aqua/CKSSt/src/deps_compat.jl:16
  Expression: result ⊜ true
   Evaluated: ⟪result: 😭 FAILED: Rasters [a3a2b9e3-a471-40c9-b274-f788e487c689]
    `/home/runner/work/GDAL.jl/GDAL.jl/downstream/Project.toml` does not specify `compat` for:
    GDAL

https://github.com/JuliaGeo/GDAL.jl/actions/runs/6277253339/job/17048615674?pr=161#step:6:877

@visr visr changed the title allow PROJ_jll v901 test GDAL 3.7.2 Sep 22, 2023
@rafaqz
Copy link
Member

rafaqz commented Sep 22, 2023

Yeah I can add a direct dep, more correct than using ArchGDAL.GDAL anyway

@visr
Copy link
Member Author

visr commented Sep 22, 2023

Yeah it'll probably be a while before ArchGDAL is pure-julia and can drop the GDAL dependency.

@visr
Copy link
Member Author

visr commented Sep 22, 2023

I'll release this version, which allows both old and new GDAL/GEOS/PROJ versions, as a patch release. This to unblock some issues using the wrapper packages together, like JuliaGeo/LibGEOS.jl#182 (comment).

Then I will wrap the new functions from GDAL 3.7. Wrapping those functions means I need to drop support for GDAL 3.6 since it won't have those methods, which means it is also dropping support for PROJ < 9.3. This shall be tagged as a new minor release.

@visr visr merged commit 04f9680 into master Sep 22, 2023
13 of 15 checks passed
@visr visr deleted the visr-patch-1 branch September 22, 2023 20:24
@visr visr mentioned this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants