Makie plotting LibGEOS MultiLineString shows additional lines

[jaakkor2]

using GLMakie, GeoInterfaceMakie, LibGEOS
GeoInterfaceMakie.@enable(LibGEOS.AbstractGeometry)
mls = readgeom("MULTILINESTRING ((0 0,3 0,3 3,0 3,0 0),(1 1,2 1,2 2,1 2,1 1))")
plot(mls)

results in with extra line (0,0)->(1,1)

This in Makie

lines([0,3,3,0,0,NaN,1,2,2,1,1],[0,0,3,3,0,NaN,1,1,2,2,1])

gives the expected output

[rafaqz]

Any ideas about this @jw3126 ? Looks like the inner ring is being included together with the the outer ring so the start and end points join?

[jw3126]

What happens internally is that we convert to a GeometryBasics.MultiLineString

GeoInterface.jl/GeoInterfaceMakie/src/GeoInterfaceMakie.jl

Line 52 in 827af7c

function basicsgeom(geom)

and than plot that. So I think what should be checked is that:

• Does GeometryBasics.MultiLineString plot as expected?
• Does the conversion work as expected?
  I don't have the bandwidth to do this right now myself, if you want to give it a shot @jaakkor2 that would be awesome.

[jaakkor2]

This works

using GLMakie, Makie.GeometryBasics
linestring1 = LineString(Point{2, Int}[(0, 0), (3, 0), (3, 3), (0, 3), (0, 0)])
linestring2 = LineString(Point{2, Int}[(1, 1), (2, 1), (2, 2), (1, 2), (1, 1)])
multilinestring = MultiLineString([linestring1, linestring2])
plot(multilinestring)

and this works as well

using GLMakie, GeoInterfaceMakie, LibGEOS
mls = readgeom("MULTILINESTRING ((0 0,3 0,3 3,0 3,0 0),(1 1,2 1,2 2,1 2,1 1))")
plot(GeoInterfaceMakie.basicsgeom(mls))

So looks like it is not hitting the correct conversion.

[jw3126]

Thanks @jaakkor2 . I think it hits

GeoInterface.jl/GeoInterfaceMakie/src/GeoInterfaceMakie.jl

Line 69 in 827af7c

function _convert_arguments(::MC.PointBased, geom)::Tuple

For e.g. scatter this would be correct, but for lines, all Multi geometries will get messed up. So we need to intercept
multi geometries for lines.