Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the default geometry columns in GeoParquet.write be GI.geometrycolumns #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make the default geometry columns in GeoParquet.write be GI.geometrycolumns #23

wants to merge 1 commit into from

Conversation

asinghvi17
Copy link
Member

@asinghvi17 asinghvi17 commented Jul 14, 2024 •
edited
Loading

Does what it says on the tin

@rafaqz
Copy link
Member

rafaqz commented Jul 14, 2024

While we're at it should we standardise the keyword? Community interface style?

geometrycolums would make it pretty clear it's the same thing as GI.geometrycolumns

@asinghvi17
Copy link
Member Author

Yeah more standardized kwargs would be good. That will need a bigger rewrite so I'll do that when not bouncing around :D.

@rafaqz
Copy link
Member

rafaqz commented Jul 15, 2024

I think this needs a breaking bump anyway (as e.g. the output of GADM.jl won't write after this, it has a broken column name)

So we may as well do both

@asinghvi17
Copy link
Member Author

Yes this will be a problem. GADM should ideally return something usable too...

@rafaqz
Copy link
Member

rafaqz commented Jul 15, 2024

See JuliaGeo/GADM.jl#50 for GADM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asinghvi17 @rafaqz