prevent StackOverflowError in LatLon constructor

now it gives a MethodError instead fixes #47
JuliaGeo · Nov 4, 2018 · b715e35 · b715e35
1 parent 2774631
commit b715e35
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/points.jl b/src/points.jl
@@ -34,8 +34,8 @@ struct LatLon{T <: Number}
     lat::T
     lon::T
 end
-LatLon(lat, lon) = LatLon(promote(lat, lon)...)
-LatLon(;lat=NaN,lon=NaN) = LatLon(lat,lon) # Constructor that is idependent of storage order
+LatLon(lat::Number, lon::Number) = LatLon(promote(lat, lon)...)
+LatLon(;lat=NaN,lon=NaN) = LatLon(lat,lon) # Constructor that is independent of storage order
 LatLon(lla::LLA) = LatLon(lla.lat, lla.lon)
 function LatLon(x, datum::Union{Datum,Ellipsoid})
     lla = LLA(x, datum)

diff --git a/test/points.jl b/test/points.jl
@@ -12,6 +12,7 @@
     @test LatLon(lla) == latlon
     @test LatLon(1//1, 1.) == latlon
     @test LatLon(1, 1) == LatLon{Int}(1, 1)
+    @test_throws MethodError LatLon(missing, missing)
 
     @test LLA(latlon) == lla