Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Julia 0.7 and 1.0 compatibility #44

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Migrate to Julia 0.7 and 1.0 compatibility #44

merged 2 commits into from
Aug 22, 2018

Conversation

garborg
Copy link
Member

@garborg garborg commented Aug 21, 2018

No description provided.

@garborg
Copy link
Member Author

garborg commented Aug 21, 2018

I left the custom atan2d implementation's name unchanged because it seemed less confusing to me (knowing whether calling base's version or not and we call one-arg methods of atand as well in the code).

Seems like a straightforward PR, so I'll merge it in a day or two if @c42f and @andyferris are busy elsewhere.

@visr
Copy link
Member

visr commented Aug 21, 2018

Great, thanks! Looks like you still need to update CI, removing 0.6, adding 1.0. For Travis to work it needs a using Pkg; prefix, and for AppVeyor you can use the format of https://github.com/JuliaCI/Appveyor.jl now.

@garborg
Copy link
Member Author

garborg commented Aug 21, 2018 via email

@andyferris
Copy link
Contributor

Thanks :)

Let’s fix the CI and then merge and tag. Exciting days!

@garborg
Copy link
Member Author

garborg commented Aug 22, 2018

Not sure why the mac build hung for julia 1 on travis, but it passed everywhere it didn't hang. I assume this is a common travis/julia issue these days and we're good to go, but I'll leave it to someone who's been around recently.

@visr
Copy link
Member

visr commented Aug 22, 2018

Restarted the hanging one, now it works :)

@garborg garborg merged commit e4bac3b into master Aug 22, 2018
@garborg garborg deleted the compat71 branch August 22, 2018 14:32
@garborg
Copy link
Member Author

garborg commented Aug 22, 2018

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants