add DimensionalData extension #178
Conversation
ext/GeometryOpsDimensionalDataExt/GeometryOpsDimensionalDataExt.jl
Outdated
Show resolved
Hide resolved
| import GeometryOps as GO | ||
| import GeoInterface as GI | ||
|
|
||
| function GO.polygonize(A::DD.AbstractDimArray; dims=(DD.X(), DD.Y()), crs=GI.crs(A), kw...) |
There was a problem hiding this comment.
What happens with the dims that aren't given (time etc)?
There was a problem hiding this comment.
Yeah I haven't done that yet, this should be WIP.
But I image we make a feature collection with a feature for each slice, and put the lookup values as properties?
Otherwise return a DimArray of geoms of the remaining dimensions ?
Probably a single feature collection or table is most useful?
There was a problem hiding this comment.
Actually this is a case for R style vector data cubes.
But we can just broadcast over the other dimensions and get a DimArray of X/Y geometries with time/etc dimensions.
We should be able to write that directly as a FeatureCollection with GeoJSON/ArchGDAL/Shapefile without any more work as long as we name the array :geometry.
There was a problem hiding this comment.
Do we then want to add an assert here that the dims can only have length 2?
|
Does that last commit set minimum version to Julia 1.10 instead of 1.9? |
|
Oops wrong commit message, we can fix it in the squash |
|
Is this just waiting on the datacube stuff/implementation? |
|
Waiting for me to have time 😭 |
This adds a DD extension for
polygonizeso that any DD array can be polygonized with X/Y (or custom withdimskeyword) lookup values.