Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Makie extension #189

Merged
merged 10 commits into from
Jan 7, 2024
Merged

add Makie extension #189

merged 10 commits into from
Jan 7, 2024

Conversation

rafaqz
Copy link
Member

@rafaqz rafaqz commented Dec 27, 2023

No description provided.

@rafaqz rafaqz requested review from visr and jw3126 December 27, 2023 15:52
@rafaqz
Copy link
Member Author

rafaqz commented Dec 27, 2023 •
edited
Loading

1.6 strikes again... should we:

  1. Just use 1.9 and up now, 1.10 is already out
    2. Don't test Makie plots below 1.9

jw3126
jw3126 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@jw3126 jw3126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM should we bump the version?

@jaakkor2
Copy link
Contributor

jaakkor2 commented Jan 7, 2024

Makie should not be listed in the [deps]-section https://github.com/JuliaGeo/LibGEOS.jl/blob/makie/Project.toml#L13 to keep dependencies light.

@rafaqz
Copy link
Member Author

rafaqz commented Jan 7, 2024 •
edited
Loading

Oh nice catch thats a mistake. Its already there as a week dep

@rafaqz rafaqz merged commit e58a9cb into master Jan 7, 2024
11 checks passed
@rafaqz rafaqz deleted the makie branch January 7, 2024 12:58
rafaqz added a commit that referenced this pull request Jan 7, 2024
@rafaqz
add Makie extension (#189)
da9b907 
* add Makie extension

* tweak

* fix deps versions

* actually add the extension

* better extension name

* test fixes

* fix Aqua again

* stop supporting < 1.9

* remove dup makie dep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jw3126 jw3126 jw3126 approved these changes

@visr visr Awaiting requested review from visr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaqz @jaakkor2 @jw3126