Add support for writing Feature Collection without properties

[eliascarv]

Shapefile.jl breaks when writing a Feature Collection without properties.
MWE:

julia> import GeoJSON

julia> fc = GeoJSON.read("test.geojson")
FeatureCollection with 3 Features

julia> import Shapefile

julia> Shapefile.write("test.shp", fc)
ERROR: MethodError: reducing over an empty collection is not allowed; consider supplying `init` to the reducer
Stacktrace:
  [1] reduce_empty(op::Base.MappingRF{Shapefile.var"#21#24", Base.BottomRF{…}}, ::Type{Tables.ColumnsRow{…}})
    @ Base ./reduce.jl:361
...

Contents of the test.geojson file:

{
    "type": "FeatureCollection",
    "features": [
        {
            "type": "Feature",
            "geometry": {
                "type": "Point",
                "coordinates": [
                    0.0,
                    0.0
                ]
            },
            "properties": {}
        },
        {
            "type": "Feature",
            "geometry": {
                "type": "Point",
                "coordinates": [
                    1.0,
                    1.0
                ]
            },
            "properties": {}
        },
        {
            "type": "Feature",
            "geometry": {
                "type": "Point",
                "coordinates": [
                    2.0,
                    2.0
                ]
            },
            "properties": {}
        }
    ]
}

[rafaqz]

Thanks!

That's a weird build error, you could try to isolate it by not running CI on Windows and/or 1.9

[eliascarv]

@rafaqz sorry, but I don't have permissions to run the CI.

[rafaqz]

Oh I just meant to comment it out in the workflow and push another commit.

Even with permissions github actions doesn't let us just trigger one on its own, it just runs everything so will probably kill the job from the same failure again.

[rafaqz]

Like here:
https://github.com/JuliaGeo/Shapefile.jl/blob/main/.github/workflows/CI.yml#L16

[eliascarv]

I honestly don't know what's going on with the CI, locally the tests pass.
Version info:

julia> versioninfo()
Julia Version 1.10.2
Commit bd47eca2c8a (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 12 × Intel(R) Core(TM) i5-10400 CPU @ 2.90GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, skylake)
Threads: 1 default, 0 interactive, 1 GC (on 12 virtual cores)

[rafaqz]

Yep you're on 1.10 linux! Thats why I'm suggesting to comment out windows and 1.9 in the CI matrix and see what happens

https://github.com/JuliaGeo/Shapefile.jl/blob/main/.github/workflows/CI.yml#L16

[eliascarv]

Strange, now it works @rafaqz.

[rafaqz]

Not so strange :)

Not try with 1.9 but not windows, etc...

[eliascarv]

Commenting Windows only also works. Now I will comment only 1.9.

[eliascarv]

Commenting 1.9 only also works. @rafaqz, the problem appears to be related to Julia 1.9 running on Windows.

[rafaqz]

Ah cool good that its only one. Not sure how to specify not testing that though!

If you can work out how to not test 1.9 on windows that would be perfect, otherwise we can just turn off windows for now.

[eliascarv]

@rafaqz done. Ready for review.

[rafaqz]

LGTM

[eliascarv]

@rafaqz, can you release a patch with this PR?