Use a package extension for GLMakie-based functionality #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albert-de-montserrat
approved these changes
Sep 15, 2023
|
Ready to be merged? |
|
Thanks for the changes and apologies for the delay in merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the optional plotting code from Requires.jl to package extensions for newer Julia versions. I kept backwards compatibility by still using Requires.jl for old Julia versions. This cuts the loading time
using GLMakie, GeoParamsfor me by something between 0.5 and 1.5 seconds. However, there is still a lot of recompilation left, so this should be investigated in the future.Caveats:
using GLMakie, GeoParamsworks on Julia v1.8 and v1.9. I do not know whether the plotting routines are tested in CI (see Add code coverage reports #103) but I will assume that everything is fine if CI passes.