Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set default values for G and nu in SetConstantElasticity() #136

Merged
merged 5 commits into from
Dec 5, 2023
Merged

set default values for G and nu in SetConstantElasticity() #136

merged 5 commits into from
Dec 5, 2023

Conversation

Dr3ven
Copy link
Collaborator

@Dr3ven Dr3ven commented Dec 1, 2023

Using nothing for G and ν makes SetConstantElasticity() without any input arguments produce NaNs. To fix that default values without Units are set.

albert-de-montserrat
albert-de-montserrat approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@albert-de-montserrat albert-de-montserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks!

@albert-de-montserrat albert-de-montserrat merged commit 099018f into main Dec 5, 2023
20 checks passed
@albert-de-montserrat albert-de-montserrat deleted the nm-defaultvals-constantelast branch December 5, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albert-de-montserrat albert-de-montserrat albert-de-montserrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dr3ven @albert-de-montserrat