Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several bugfixes and features #175

Merged
merged 9 commits into from
Feb 19, 2024
Merged

Several bugfixes and features #175

merged 9 commits into from
Feb 19, 2024

Conversation

albert-de-montserrat
Copy link
Member

@albert-de-montserrat albert-de-montserrat commented Feb 19, 2024 •
edited
Loading

  • Removes GLMakie.jl from [deps], so that it's only a weak dependency.
  • Corrects the values of several parameters in the creep laws database.
  • Values from the creep law database can now be over loaded. Example:
diffusion_law = Diffusion.dry_anorthite_Rybacki_2006
p = SetDiffusionCreep(diffusion_law; n = 1NoUnits)
@assert p.n.val == 1.0

boriskaus
boriskaus approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@boriskaus boriskaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@albert-de-montserrat albert-de-montserrat merged commit 6581b53 into main Feb 19, 2024
16 of 17 checks passed
@albert-de-montserrat albert-de-montserrat deleted the adm/fixups branch February 19, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boriskaus boriskaus boriskaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albert-de-montserrat @boriskaus