Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector density, melt fraction and heat capacity #192

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Vector density, melt fraction and heat capacity #192

merged 5 commits into from
Apr 8, 2024

Conversation

boriskaus
Copy link
Member

This PR allows specifying vectors with Density, HeatCapacity and MeltFraction data and retrieving them with indices.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 12 lines in your changes are missing coverage. Please review.

Files Patch % Lines
src/Density/Density.jl 63.63% 4 Missing ⚠️
src/Energy/HeatCapacity.jl 55.55% 4 Missing ⚠️
src/MeltFraction/MeltingParameterization.jl 60.00% 4 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

Copy link
Member

@albert-de-montserrat albert-de-montserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@boriskaus boriskaus merged commit 25b5cb1 into main Apr 8, 2024
16 of 19 checks passed
@boriskaus boriskaus deleted the bk-mm branch April 8, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants