improve merge(meshes) #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrumbiegel
reviewed
Jul 11, 2023
| m1 = meshes[1] | ||
| ps = copy(coordinates(m1)) | ||
| fs = copy(faces(m1)) | ||
| ps = reduce(vcat, coordinates.(meshes)) |
There was a problem hiding this comment.
couldn't this all be written with a single allocated vector for ps and fs, and writing to that in the loop? We should know all lengths
There was a problem hiding this comment.
It surely could.
This was just faster than the more elaborate allocate+loop versions I tested.
There was a problem hiding this comment.
Is that an acceptable answer to merge this ? ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings allocations down to a fixed number and improves runtime by about x3 in our application.
Note:
reduce(vcat, ..)plus broadcasting is faster thanmapreducefor some reason