Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crop method for Grid #1041

Merged
merged 30 commits into from
Sep 5, 2024
Merged

Add Crop method for Grid #1041

merged 30 commits into from
Sep 5, 2024

Conversation

eliascarv
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 74.17219% with 39 lines in your changes missing coverage. Please review.

Project coverage is 88.02%. Comparing base (d5477dc) to head (c9d95e7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/utils/misc.jl 75.40% 30 Missing ⚠️
src/transforms/crop.jl 57.14% 6 Missing ⚠️
src/indices.jl 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1041      +/-   ##
==========================================
- Coverage   88.42%   88.02%   -0.41%     
==========================================
  Files         186      186              
  Lines        5676     5778     +102     
==========================================
+ Hits         5019     5086      +67     
- Misses        657      692      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliascarv eliascarv marked this pull request as ready for review September 5, 2024 11:44
src/transforms/crop.jl Outdated Show resolved Hide resolved
src/transforms/crop.jl Outdated Show resolved Hide resolved
src/transforms/crop.jl Outdated Show resolved Hide resolved
src/domains/meshes.jl Outdated Show resolved Hide resolved
Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs to handle cases where some of the findfirst and findlast return nothing.

eliascarv and others added 4 commits September 5, 2024 15:32
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/transforms/crop.jl Outdated Show resolved Hide resolved
src/transforms/crop.jl Outdated Show resolved Hide resolved
src/transforms/crop.jl Outdated Show resolved Hide resolved
src/utils/misc.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/transforms/crop.jl Outdated Show resolved Hide resolved
src/transforms/crop.jl Outdated Show resolved Hide resolved
src/transforms/crop.jl Outdated Show resolved Hide resolved
src/utils/misc.jl Outdated Show resolved Hide resolved
src/utils/misc.jl Outdated Show resolved Hide resolved
src/indices.jl Outdated Show resolved Hide resolved
src/indices.jl Outdated Show resolved Hide resolved
@juliohm juliohm merged commit 2f097e5 into master Sep 5, 2024
14 of 16 checks passed
@juliohm juliohm deleted the crop-grid branch September 5, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants