-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Add support for parsing 8-digit and 4-digit hex notations #371
Conversation
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
=========================================
+ Coverage 77.94% 78.04% +0.1%
=========================================
Files 11 11
Lines 866 870 +4
=========================================
+ Hits 675 679 +4
Misses 191 191
Continue to review full report at Codecov.
|
Please note the following: julia> parse(Colorant, "0xFF8800AA") # opaque purple
ARGB{N0f8}(0.533,0.0,0.667,1.0)
julia> parse(RGBA, "0xFF8800AA") # still opaque purple
RGBA{N0f8}(0.533,0.0,0.667,1.0) We have another option, which refers to the first argument of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice. Do all those @inbounds
annotations really make a difference?
Perhaps there is little difference in terms of the speed on Julia v1.3.0 and v1.0.5. They are slower than v1.2.0 (especially on Windows) for some unclear reason. I added Since I don't have enough time to investigate and the cause has not been identified, |
I merged #390. I also changed |
Since PR #387 was merged, we can merge this. |
This adds the support for parsing 8-digit and 4-digit hex notations following the manner mentioned in #353 (comment).
Do not merge this PR before the decision of #353 for the consistency.