Fix DE_94 & DE_CMC color difference metrics
#461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #461 +/- ##
==========================================
+ Coverage 91.21% 91.30% +0.09%
==========================================
Files 9 9
Lines 956 955 -1
==========================================
Hits 872 872
+ Misses 84 83 -1
Continue to review full report at Codecov.
|
kimikage
changed the title
DE_CMC color difference metricDE_94 & DE_CMC color difference metrics
This makes `DE_94` and `DE_CMC` quasimetric. Within those metrics, the first argument of `colordiff` is taken as the reference color. This adds the weight parameters `k1` and `k2` to `DE_94`. This also makes the omission of the metric constructor arguments more flexible.
kimikage
commented
May 4, 2021
Comment on lines
-368
to
+374
| c isa XYZ && return ai | ||
| c isa XYZ && return c |
There was a problem hiding this comment.
😭
I am not going to backport this to v0.12. As a workaround, if the second argument is XYZ, please convert it to something other than XYZ (e.g. xyY).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
DE_94andDE_CMCquasimetric. Within those metrics, the first argument ofcolordiffis taken as the reference color. This adds the weight parametersk1andk2toDE_94.This also makes the omission of the metric constructor arguments more flexible.
Edit:DoneDE_94seems to have a similar problem. I will fix it as well.Fixes #438