-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Float32
to calculate DE_2000
for low precision colors
#494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
==========================================
+ Coverage 93.64% 93.80% +0.15%
==========================================
Files 9 9
Lines 1118 1146 +28
==========================================
+ Hits 1047 1075 +28
Misses 71 71
Continue to review full report at Codecov.
|
At the moment, this uses Probably, |
46cebc6
to
83d1a5f
Compare
I would like to determine if it is worth calculating |
FWIW, I doubt that anyone is really using it for |
5ee4a90
to
99e5bb5
Compare
Float32
to calculate DE_2000
for low precision colorsFloat32
to calculate DE_2000
for low precision colors
39590c8
to
793b7d9
Compare
This speeds up the calculation of `DE_2000` while ensuring the accuracy of `5e-5`. This changes not only the type of intermediate variables, but also the return type.
Probably the last bottleneck is I've spent too much time improving |
Since this change is related to issue #496 as well as speed, I would like to merge this. |
This speeds up the calculation of
DE_2000
while ensuring the accuracy of5e-5
.This changes not only the type of intermediate variables, but also the return type. (cf. #477)
This also fixes typos in the(separated to #499)DE_2000
test data.Benchmark