Mitigate inference problems in color conversions #508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
cnvt
instead of the top-levelconvert
when source and destination are both known colors.This also blocks the propagation of inference failures by adding type assertions to the result of
convert
.However, these changes do not solve the essential problem (#496). So, this PR is for reference only, and I have no plans to merge this for now.By PR #510, we can see the practical effects, e.g.:
I haven't solved the problem yet, though.