-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix union{} ambiguity #527
fix union{} ambiguity #527
Conversation
Codecov ReportBase: 94.33% // Head: 94.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #527 +/- ##
==========================================
- Coverage 94.33% 94.09% -0.24%
==========================================
Files 9 9
Lines 1270 1270
==========================================
- Hits 1198 1195 -3
- Misses 72 75 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'm wondering if someone could review this? The test coverage drop does not seem related to this PR. |
will make a release later |
@Roger-luo @johnnychen94 this PR doesn't have any tests to actually confirm the fix, and AFAIK the fix doesn't work. |
@aplavin yeah I think you are right, I just realize But this does not work for
I don't have a good way to fix this now. |
I agree, and think this PR should be reverted so that not to confuse future readers. |
This reverts commit 1a153e3.
I realize that I shouldn't make the release on the master branch since there are plenty of breaking changes made by @kimikage since v0.12.8. Thus I've made a backport release branch https://github.com/JuliaGraphics/Colors.jl/tree/release-0.12 with a new patch release v0.12.10 to supersede v0.12.9. v0.12.10 includes #521 (@brenhinkeller) and #525(@williamjsdavis) as bug fixes. I've also submitted a yank patch for v0.12.9 to General JuliaRegistries/General#74192 |
See JuliaLang/julia#47840