Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compat for Colors and release 1.0.2 #21

Merged
merged 1 commit into from
Mar 15, 2020
Merged

Bump compat for Colors and release 1.0.2 #21

merged 1 commit into from
Mar 15, 2020

Conversation

kimikage
Copy link
Contributor

No description provided.

@kimikage
Copy link
Contributor Author

kimikage commented Mar 15, 2020

BTW, I cannot give a reasonable explanation why this is not v2.0.0.:confused: Of course, this does not change the API of Graphics, so this is never v2.0.0.

@timholy timholy merged commit d63a5e1 into JuliaGraphics:master Mar 15, 2020
@timholy
Copy link
Member

timholy commented Mar 15, 2020

Thanks!

Keep in mind that any package needing this one but also providing color manipulations will have to depend directly on Colors/ColorTypes or a package that reexports them. So the version check goes there.

@kimikage
Copy link
Contributor Author

I'm sorry I didn't explain it enough. My concern is why Graphics depends on Colors.
Most parts of Graphics are only interface declarations, and there are few implementations. I think the following should be the responsibility of the providers of the implementations.

Graphics.jl/src/Graphics.jl

Lines 418 to 422 in d63a5e1

# set source color as a Color
function set_source(gc::GraphicsContext, c::Color)
rgb = convert(RGB, c)
set_source_rgb(gc, rgb.r, rgb.g, rgb.b)
end

However, since Graphics is v1, it will not be changed for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants