This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fix super->supertype deprecation warning #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how can deprecations warnings break testing? |
|
They don't. I just wanted to fix test warnings before tagging. |
|
The last tag of Gtk was in mid-June. |
| @@ -16,9 +16,9 @@ immutable _GList{T} <: _LList{T} | |||
| prev::Ptr{_GList{T}} | |||
| end | |||
| eltype{T}(::Type{_LList{T}}) = T | |||
| eltype{L<:_LList}(::Type{L}) = eltype(super(L)) | |||
| eltype{L<:_LList}(::Type{L}) = eltype(supertype(L)) | |||
There was a problem hiding this comment.
is this in Compat 0.8.0 ? nevermind, yes it is JuliaLang/Compat.jl@d360cca
timholy
force-pushed
the
teh/super
branch
2 times, most recently
from
bc3929f
to
f6ff2a3
Compare
|
There's some Homebrew problem. Will this be exacerbated if I tag a new version, or is it already an issue now? |
|
ref JuliaPackaging/Homebrew.jl#121 so it's been a problem for a while, but may be work-around-able with a |
|
OK, so I won't let this hold up tagging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to tag a new release, since the current one fails on 0.5 and makes packages like ProfileView fail their tests.