Initial shot at using Gtk on Julia 1.3+ #447

staticfloat · 2019-10-03T23:51:26Z

Note that this requires the Julia 1.3+ version of cairo as well (which is why the Project.toml shows Cairo.jl as being dev'ed)

~~This doesn't work totally yet; it crashes halfway through the tests on my mac because it can't load some icons.~~

This now passes all tests locally, but the windows that pop up are never drawn into; they remain white. More debugging information below.

…XDG_DATA_DIRS` and more~

src/Gtk.jl

.gitignore

Co-Authored-By: Mosè Giordano <giordano@users.noreply.github.com>

To attract a wild Mose to your project, leave a newline at the end of your `.gitignore` as a gentle offering.

Project.toml

tknopp · 2019-10-18T06:17:50Z

For reference here is a list of TODO items:

Make it work on Windows, Travis could be enabled
Make it work on Linux
We get on Mac this warning: gdk-pixdump possibly not installed correctly JuliaPackaging/Homebrew.jl#121 (comment). If I recall we did not have this with the working homebrew setup. From that link one can crawl the history since maybe @staticfloat has resolved this at that time
Package loading went from 2s to 12s. This is not really acceptable given that the linux setup currently runs fine.
Fix the warning: (julia:4891): Gtk-WARNING **: 21:55:48.913: infinite surface size not supported

giordano · 2019-10-18T08:01:07Z

src/Gtk.jl

+        dirname(hicolor_icons_dir),
+        joinpath(dirname(GTK3_jll.libgdk3_path), "..", "share"),
+        get(ENV, "XDG_DATA_DIRS", nothing),
+    ]), ":")


Shouldn't the separator be a semicolon on Windows? @ianshmean can you please check if this fixes the issue you reported yesterday? As far as I can see, this variable is not currently set on Windows, so I'm not sure this will be sufficient...

codecov · 2019-10-21T08:09:45Z

Codecov Report

Merging #447 into master will increase coverage by 0.53%.
The diff coverage is 58.06%.

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage    47.5%   48.03%   +0.53%     
==========================================
  Files          31       31              
  Lines        2128     2117      -11     
==========================================
+ Hits         1011     1017       +6     
+ Misses       1117     1100      -17

Impacted Files	Coverage Δ
src/GLib/GLib.jl	`70% <ø> (ø)`	⬆️
src/events.jl	`50.7% <ø> (-2.63%)`	⬇️
src/gtktypes.jl	`78.57% <ø> (ø)`	⬆️
src/boxes.jl	`5.4% <0%> (ø)`	⬆️
src/cairo.jl	`42.1% <0%> (ø)`	⬆️
src/GLib/signals.jl	`75.11% <100%> (+0.35%)`	⬆️
src/Gtk.jl	`90.47% <100%> (+30.47%)`	⬆️
src/displays.jl	`9.52% <12.5%> (ø)`	⬆️
src/selectors.jl	`21.42% <0%> (-1.83%)`	⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcfdf5...da2cea7. Read the comment docs.

staticfloat · 2019-10-24T22:05:48Z

On my linux desktop, using Gtk on this branch takes 15s, which is abysmal.

We know that at least 30% of this is due to a regression in type inference, at least 10% of it is due to missing precompile statements in Pkg, and there is a suspiciously large amount of code being generated within the JLL precompilation files. We're looking into it, but these issues almost certainly will not be fixed in 1.3, but will have to be addressed with a 1.3.1 release.

staticfloat · 2019-10-24T23:08:53Z

Windows seems to be failing to create the gdk-pixbuf cache. I'm investigating.

tknopp · 2019-10-25T06:03:36Z

Windows seems to be failing to create the gdk-pixbuf cache. I'm investigating.

Just on AppVeyor, right? On Travis CI its is working on windows. The only thing is that one warning we see on all platforms.

staticfloat · 2019-10-25T06:41:38Z

That's correct; I'm guessing there's some kind of DLL missing in the cut-down Travis environment or something, because in my test on a full windows workstation, it works just fine. I'm not going to look into it anymore then. :)

tknopp · 2019-10-25T06:59:07Z

If Travis runs reliably, there is no need for appVeyor.

giordano · 2019-10-25T07:05:53Z

If Travis runs reliably, there is no need for appVeyor.

In my all-platforms build Travis timed out on Windows (but cannot see why on the phone): https://travis-ci.com/giordano/Gtk.jl/builds/133476408

staticfloat · 2019-10-25T07:11:45Z

It looks like the while sleep 540 ; do echo "===== saying hello to Travis ====="; done loop keeps running in the background forever.

giordano · 2019-10-25T07:19:10Z

That was to keep Travis awake in the aarch64 build 😩

staticfloat · 2019-10-25T07:25:56Z

I think you're going to need to do a little bit of job control on windows; after the main script has ended, you'll need to kill your background task. This is probably only a problem on windows.

Run test on Travis on x86 and arm64, too

jonathanBieler · 2019-11-28T20:16:54Z

I'm trying this on windows 10 (julia v1.3 and Cairo master) but I'm getting this :

julia> using Gtk
[ Info: Precompiling Gtk [4c0ca9eb-093a-5379-98c5-f87ac0bbbf44]
WARNING: redefining constant libgdk
WARNING: redefining constant libgtk

(julia.exe:9416): GLib-GObject-WARNING **: 21:11:40.394: cannot register existing type 'GApplication'

(julia.exe:9416): GLib-GObject-WARNING **: 21:11:40.395: cannot add private field to invalid (non-instantiatable) type '<invalid>'

(julia.exe:9416): GLib-GObject-WARNING **: 21:11:40.396: cannot register existing type 'GActionGroup'

(julia.exe:9416): GLib-GObject-CRITICAL **: 21:11:40.396: g_type_interface_add_prerequisite: assertion 'G_TYPE_IS_INTERFACE (interface_type)' failed

(julia.exe:9416): GLib-CRITICAL **: 21:11:40.396: g_once_init_leave: assertion 'result != 0' failed

(julia.exe:9416): GLib-GObject-CRITICAL **: 21:11:40.396: g_type_add_interface_static: assertion 'G_TYPE_IS_INSTANTIATABLE (instance_type)' failed

(julia.exe:9416): GLib-GObject-WARNING **: 21:11:40.396: cannot register existing type 'GActionMap'

(julia.exe:9416): GLib-GObject-CRITICAL **: 21:11:40.396: g_type_interface_add_prerequisite: assertion 'G_TYPE_IS_INTERFACE (interface_type)' failed

(julia.exe:9416): GLib-CRITICAL **: 21:11:40.397: g_once_init_leave: assertion 'result != 0' failed

(julia.exe:9416): GLib-GObject-CRITICAL **: 21:11:40.398: g_type_add_interface_static: assertion 'G_TYPE_IS_INSTANTIATABLE (instance_type)' failed

(julia.exe:9416): GLib-CRITICAL **: 21:11:40.398: g_once_init_leave: assertion 'result != 0' failed

(julia.exe:9416): GLib-GObject-CRITICAL **: 21:11:40.399: g_type_register_static: assertion 'parent_type > 0' failed

(julia.exe:9416): GLib-GObject-WARNING **: 21:11:40.400: cannot add private field to invalid (non-instantiatable) type '<invalid>'

(julia.exe:9416): GLib-CRITICAL **: 21:11:40.400: g_once_init_leave: assertion 'result != 0' failed
ERROR: LoadError: LoadError: Could not find gtk_application in libgtk. This is likely a issue with a missing Gtk.jl version check.
Stacktrace:
 [1] error(::String) at .\error.jl:33
 [2] top-level scope at C:\Users\User\.julia\dev\Gtk\src\gtktypes.jl:17
 [3] include at .\boot.jl:328 [inlined]
 [4] include_relative(::Module, ::String) at .\loading.jl:1105
 [5] include at .\Base.jl:31 [inlined]
 [6] include(::String) at C:\Users\User\.julia\dev\Gtk\src\Gtk.jl:2
 [7] top-level scope at C:\Users\User\.julia\dev\Gtk\src\Gtk.jl:53
 [8] include at .\boot.jl:328 [inlined]
 [9] include_relative(::Module, ::String) at .\loading.jl:1105
 [10] include(::Module, ::String) at .\Base.jl:31
 [11] top-level scope at none:2
 [12] eval at .\boot.jl:330 [inlined]
 [13] eval(::Expr) at .\client.jl:425
 [14] top-level scope at .\none:3
in expression starting at C:\Users\User\.julia\dev\Gtk\src\gtktypes.jl:117
in expression starting at C:\Users\User\.julia\dev\Gtk\src\Gtk.jl:53
ERROR: Failed to precompile Gtk [4c0ca9eb-093a-5379-98c5-f87ac0bbbf44] to C:\Users\User\.julia\compiled\v1.3\Gtk\Vjnq0_6yYR4.ji.
Stacktrace:
 [1] error(::String) at .\error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at .\loading.jl:1283
 [3] _require(::Base.PkgId) at .\loading.jl:1024
 [4] require(::Base.PkgId) at .\loading.jl:922
 [5] require(::Module, ::Symbol) at .\loading.jl:917

Is it supposed to work ? Maybe I should try with a clean install.

giordano · 2019-11-28T21:53:38Z

WARNING: redefining constant libgdk
WARNING: redefining constant libgtk

doesn't sound right I think. Do you still have something in deps/?

Maybe I should try with a clean install.

That would make sure that you're not messing up with some leftover of previous installations

tknopp · 2019-11-28T22:06:19Z

Current travis run looks ok despite x86 on windows.

tknopp · 2019-11-29T08:20:58Z

@jonathanBieler: The JLL branch had an issue with existing deps/* files which were in the gitignore. Try switch to master where I have fixed this and make sure that there is no deps directory anymore.

giordano mentioned this pull request Oct 9, 2019

_jl_libcairo -> libcairo #448

Closed

staticfloat added 4 commits October 17, 2019 02:19

Initial shot at using Gtk on Julia 1.3+

a351735

Update Travis and appveyor

eaa0d04

Merge __init__() functions

0513a7d

On-demand calculation of gdk-pixbuf loader cache, proper setting of `…

0b7a864

…XDG_DATA_DIRS` and more~

staticfloat force-pushed the sf/jll_packages branch from bd671b6 to 0b7a864 Compare October 17, 2019 09:31

giordano reviewed Oct 17, 2019

View reviewed changes

src/Gtk.jl Outdated Show resolved Hide resolved

.gitignore Outdated Show resolved Hide resolved

staticfloat and others added 4 commits October 17, 2019 09:35

Update src/Gtk.jl

649fe0e

Co-Authored-By: Mosè Giordano <giordano@users.noreply.github.com>

Add hicolor_icon_theme_jll

1a4faff

Add newline to the end of .gitignore

723b85c

To attract a wild Mose to your project, leave a newline at the end of your `.gitignore` as a gentle offering.

Send proper bitmask for what kinds of events uv_fd can emit

32b9b3b

staticfloat force-pushed the sf/jll_packages branch from a758e89 to 32b9b3b Compare October 17, 2019 18:14

Delete MutableArtifacts.toml (will be generate during init)

f4c1849

giordano reviewed Oct 17, 2019

View reviewed changes

Project.toml Show resolved Hide resolved

giordano reviewed Oct 18, 2019

View reviewed changes

correct path separator on windows

b13ecf4

tknopp added 3 commits October 21, 2019 10:10

add windows to travis

7e97e00

comment out screen_size test on windows

f3cdb2c

comment out more tests on windows

ff09832

jonathanBieler mentioned this pull request Oct 24, 2019

Deps fail with Cairo.jl #452

Closed

staticfloat added 2 commits October 24, 2019 14:56

Attempt to auto-install custom version of Cairo

6aab959

using, not import.

e500dca

giordano mentioned this pull request Oct 28, 2019

Rough estimate - how much disk space will the static server need? JuliaPackaging/PkgServer.jl#1

Closed

tknopp mentioned this pull request Oct 30, 2019

issue: "using Gtk" : could not load library "libgobject-2.0" #363

Closed

giordano and others added 2 commits November 9, 2019 21:39

Run test on Travis on x86 and arm64, too

b60ea13

Merge pull request #1 from giordano/travis-more-platforms

3ecb435

Run test on Travis on x86 and arm64, too

giordano mentioned this pull request Nov 26, 2019

Usage of Gtk on windows needs a warning #454

Merged

Merge branch 'master' into sf/jll_packages

da2cea7

tknopp merged commit b00658d into JuliaGraphics:master Nov 28, 2019

This was referenced Nov 29, 2019

WIP: Move to BinaryProvider build #439

Closed

get libz from BinaryBuilder system #387

Closed

vtjnash mentioned this pull request Dec 2, 2019

Optimize artifact loading during Pkg.build stage, remove Pkg application dependency from JLL libraries JuliaPackaging/BinaryBuilder.jl#538

Closed

timholy mentioned this pull request Dec 11, 2019

Warn on windows #467

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial shot at using Gtk on Julia 1.3+ #447

Initial shot at using Gtk on Julia 1.3+ #447

staticfloat commented Oct 3, 2019 •

edited

Loading

tknopp commented Oct 18, 2019 •

edited

Loading

giordano Oct 18, 2019

codecov bot commented Oct 21, 2019 •

edited

Loading

staticfloat commented Oct 24, 2019

staticfloat commented Oct 24, 2019

tknopp commented Oct 25, 2019

staticfloat commented Oct 25, 2019 •

edited

Loading

tknopp commented Oct 25, 2019

giordano commented Oct 25, 2019

staticfloat commented Oct 25, 2019

giordano commented Oct 25, 2019

staticfloat commented Oct 25, 2019

jonathanBieler commented Nov 28, 2019 •

edited

Loading

giordano commented Nov 28, 2019 •

edited

Loading

tknopp commented Nov 28, 2019

tknopp commented Nov 29, 2019

Initial shot at using Gtk on Julia 1.3+ #447

Initial shot at using Gtk on Julia 1.3+ #447

Conversation

staticfloat commented Oct 3, 2019 • edited Loading

tknopp commented Oct 18, 2019 • edited Loading

giordano Oct 18, 2019

Choose a reason for hiding this comment

codecov bot commented Oct 21, 2019 • edited Loading

Codecov Report

staticfloat commented Oct 24, 2019

staticfloat commented Oct 24, 2019

tknopp commented Oct 25, 2019

staticfloat commented Oct 25, 2019 • edited Loading

tknopp commented Oct 25, 2019

giordano commented Oct 25, 2019

staticfloat commented Oct 25, 2019

giordano commented Oct 25, 2019

staticfloat commented Oct 25, 2019

jonathanBieler commented Nov 28, 2019 • edited Loading

giordano commented Nov 28, 2019 • edited Loading

tknopp commented Nov 28, 2019

tknopp commented Nov 29, 2019

staticfloat commented Oct 3, 2019 •

edited

Loading

tknopp commented Oct 18, 2019 •

edited

Loading

codecov bot commented Oct 21, 2019 •

edited

Loading

staticfloat commented Oct 25, 2019 •

edited

Loading

jonathanBieler commented Nov 28, 2019 •

edited

Loading

giordano commented Nov 28, 2019 •

edited

Loading