Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

add tests for GList, fix a few things related to GList #601

Merged
merged 2 commits into from
Dec 17, 2021
Merged

add tests for GList, fix a few things related to GList #601

merged 2 commits into from
Dec 17, 2021

Conversation

jwahlstrand
Copy link
Contributor

Adds tests for GList and fixes a couple of bugs. Also removes some array interface declarations that don't seem to be necessary.

  • In the string code, rename unsafe_copy! to unsafe_copyto!.
  • Explicitly convert a number to a pointer for storing numbers in a GList.
  • Add a constructor for GSList for testing purposes.
  • Remove a few standard array interface declarations that don't seem necessary since they are the default.

* In the string code, rename unsafe_copy! to unsafe_copyto!.
* Explicitly convert a number to a pointer.
* Added a constructor for GSList for testing purposes
* Removed a few standard array interface declarations that don't seem necessary since they are the default.
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #601 (30f65be) into master (d28f725) will increase coverage by 3.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   48.66%   51.93%   +3.27%     
==========================================
  Files          32       32              
  Lines        2661     2659       -2     
==========================================
+ Hits         1295     1381      +86     
+ Misses       1366     1278      -88     
Impacted Files Coverage Δ
src/GLib/GLib.jl 81.81% <ø> (+9.09%) ⬆️
src/GLib/glist.jl 68.23% <100.00%> (+49.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d28f725...30f65be. Read the comment docs.

@tknopp tknopp merged commit ce2673a into JuliaGraphics:master Dec 17, 2021
@jwahlstrand jwahlstrand deleted the glist branch December 19, 2021 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants