-
Notifications
You must be signed in to change notification settings - Fork 80
Conversation
I would actually remove the multi-process version. |
I was inclined to keep it and list it first because when running the default |
Pull Request Test Coverage Report for Build 2791421964
💛 - Coveralls |
Pull Request Test Coverage Report for Build 2791421964Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Because ist just works in toy examples for me. If the callback needs to call package code one needs to run Julia with -p and "@Everywhere using ...". Data exchange ist also more complicated. For me the multi-threaded version is much simpler. If I see it right, Julia 1.8 will give us the second thread by default. |
Noted. Threading certainly has advantages and should probably be listed first.
Where did you see that? x@X ~ % julia +beta
_
_ _ _(_)_ | Documentation: https://docs.julialang.org
(_) | (_) (_) |
_ _ _| |_ __ _ | Type "?" for help, "]?" for Pkg help.
| | | | | | |/ _' | |
| | |_| | | | (_| | | Version 1.8.0-rc3 (2022-07-13)
_/ |\__'_|_|_|\__'_| | Official https://julialang.org/ release
|__/ |
julia> Threads.nthreads()
1 In 1.9 we will have interactive threads which should make the threading approach more robust: "Threads.@Spawn now accepts an optional first argument: :default or :interactive. An interactive task desires low latency and implicitly agrees to be short duration or to yield frequently. Interactive tasks will run on interactive threads, if any are specified when Julia is started ([#42302])." (https://github.com/JuliaLang/julia/blob/df846436bb91b291be988f5e18e256d514b97347/NEWS.md) I think the best option is probably to recommend threads and then afterward, note that Distributed is also an option with caveats. |
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
=======================================
Coverage 65.60% 65.60%
=======================================
Files 32 32
Lines 2721 2721
=======================================
Hits 1785 1785
Misses 936 936 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
🙁 I thought this would be in 1.8. But anyway. I like your suggestion of just switching the order. |
to highlight potential issues with Distributed and to link to the relevant manual entries
thanks! |
Closes #636
Closes #640