Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Julia 0.7, drop 0.5 and 0.6 #292

Merged
merged 19 commits into from
Aug 11, 2018
Merged

Updates for Julia 0.7, drop 0.5 and 0.6 #292

merged 19 commits into from
Aug 11, 2018

Conversation

ararslan
Copy link
Collaborator

No description provided.

@ararslan
Copy link
Collaborator Author

Looks like the remaining 0.7 failure is the fault of Tk:

ERROR: LoadError: LoadError: LoadError: LoadError: LoadError: UndefVarError: JULIA_HOME not defined
Stacktrace:
 [1] init() at /home/travis/.julia/v0.7/Tk/src/tkwidget.jl:35

@tknopp
Copy link
Collaborator

tknopp commented May 12, 2018

@ararslan this is extremely interesting. If 0.7 is running: what do you get timings for the first plot (see JuliaLang/julia#27083 for the issue I am talking about)

Regarding the remaining 0.7 fault I would simply disable Tk.

@tknopp
Copy link
Collaborator

tknopp commented May 31, 2018

After #288 is merged it would be interesting if tests are passing then @ararslan. Lets get this package all green in CI testing!

@tknopp
Copy link
Collaborator

tknopp commented Aug 11, 2018

@ararslan: I have some further fixes for your branch aa/updates. Can you give me commit access so that I can push them?

@tknopp
Copy link
Collaborator

tknopp commented Aug 11, 2018

@ararslan: thanks!!!

Are you fine with dropping 0.6 support in Winston?

@ararslan
Copy link
Collaborator Author

Yes, and I think it is likely necessary in order to support 1.0 fully.

@tknopp
Copy link
Collaborator

tknopp commented Aug 11, 2018

Yep, but I will need help for non-trivial issues in Gtk:
JuliaGraphics/Gtk.jl#358

The other really urgent thing is to fix the Homebrew issue that makes Cairo.jl failing. This propagates through all these packages.

@tknopp
Copy link
Collaborator

tknopp commented Aug 11, 2018

@ararslan: I still do not have commit access here in Winston, although I am team member of JuliaGraphics. I think you need to "manage my access" if you click on me in the group menu.

@ararslan
Copy link
Collaborator Author

You should have write access now

@tknopp
Copy link
Collaborator

tknopp commented Aug 11, 2018

great works. I have create release-julia-0.6 as our 0.6 branch. Will push my fixes to aa/updates and push that branch to master then, since the tests are now passing.

@ararslan
Copy link
Collaborator Author

Sure, just want to make sure it passes CI before merging to master

@tknopp
Copy link
Collaborator

tknopp commented Aug 11, 2018

Of course. Although I would only look at 0.7 linux, since 1.0 and mac will not pass

@tknopp
Copy link
Collaborator

tknopp commented Aug 11, 2018

(funnily enough I am doing this on a mac, but fixed the Homebrew thingy manually)

@tknopp tknopp changed the title Updates for Julia 0.6 and 0.7, drop 0.5 Updates for Julia 0.7, drop 0.5 and 0.6 Aug 11, 2018
@tknopp
Copy link
Collaborator

tknopp commented Aug 11, 2018

very interesting. Tests pass locally on Mac, but they fail on Travis/Linux. Seems an issue with file loading.

@tknopp
Copy link
Collaborator

tknopp commented Aug 11, 2018

there is a timing issue going on, where a global variable is overwritten. That at least my guess. I cannot reproduce this on Mac but on linux.

@tknopp
Copy link
Collaborator

tknopp commented Aug 11, 2018

Tracking down this bug has been extremely annoying, but now I have it.

@tknopp tknopp merged commit 8511ec6 into master Aug 11, 2018
@tknopp tknopp deleted the aa/updates branch August 11, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants