-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Julia 0.7, drop 0.5 and 0.6 #292
Conversation
Looks like the remaining 0.7 failure is the fault of Tk:
|
@ararslan this is extremely interesting. If 0.7 is running: what do you get timings for the first plot (see JuliaLang/julia#27083 for the issue I am talking about) Regarding the remaining 0.7 fault I would simply disable Tk. |
@ararslan: I have some further fixes for your branch |
@ararslan: thanks!!! Are you fine with dropping 0.6 support in Winston? |
Yes, and I think it is likely necessary in order to support 1.0 fully. |
Yep, but I will need help for non-trivial issues in Gtk: The other really urgent thing is to fix the Homebrew issue that makes |
@ararslan: I still do not have commit access here in Winston, although I am team member of JuliaGraphics. I think you need to "manage my access" if you click on me in the group menu. |
You should have write access now |
great works. I have create |
Sure, just want to make sure it passes CI before merging to master |
Of course. Although I would only look at 0.7 linux, since 1.0 and mac will not pass |
(funnily enough I am doing this on a mac, but fixed the Homebrew thingy manually) |
very interesting. Tests pass locally on Mac, but they fail on Travis/Linux. Seems an issue with file loading. |
there is a timing issue going on, where a global variable is overwritten. That at least my guess. I cannot reproduce this on Mac but on linux. |
Tracking down this bug has been extremely annoying, but now I have it. |
No description provided.