-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Personalized PageRank Diffusion [ppr_diffusion
function]
#427
Conversation
ppr_diffusion
function] for Edge Weight Adjustmentppr_diffusion
function]
Tests fail for
This should be checked, since this did not fail in the last commit and the only change in this commit was adding the reference paper. |
Tests pass now, so the previous test fail was unrelated to this PR. That should also be checked later. |
uses SparseArrays
Would this be GPU compatible now that non mutable operations are removed? Tested training and Zygote no longer gives single element operation error! |
Let's have an implementation which works correctly with dense matrices on cpu and in later PRs we can add gpu support and add the sparse matrices performance optimization. So we are mostly fine with the current PR. |
Should I change the code back to older commits where only dense matrices were used? Or would this be ok as it is? |
rename args Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
clean code Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
remove unneeded line Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
args fix Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
rename var Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
bump. Also needs a rebase. |
done |
Continues Issue #412, takes inspiration from DGL implementation
This PR introduces a new function,
ppr_diffusion
. It calculates Personalized PageRank (PPR) diffusion based on the edge weight matrix and updates the graph with new edge weights derived from the PPR matrix.Implementation:
The function operates in several key steps: