Added node_shuffle
#429
Closed
Added node_shuffle
#429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Returns | ||
| - `g::GNNGraph`: The GNNGraph with shuffled node features. | ||
| """ | ||
| function node_shuffle(g::GNNGraph{<:COO_T}) |
There was a problem hiding this comment.
this is mutating, so it should be called node_shuffle!
| - `g::GNNGraph`: The GNNGraph with shuffled node features. | ||
| """ | ||
| function node_shuffle(g::GNNGraph{<:COO_T}) | ||
| features = g.ndata.x |
There was a problem hiding this comment.
we can have no guarantess that there exists features named x
| """ | ||
| function node_shuffle(g::GNNGraph{<:COO_T}) | ||
| features = g.ndata.x | ||
| num_nodes = size(features, 1) |
There was a problem hiding this comment.
the node dimension is the second one
| num_nodes = size(features, 1) | ||
|
|
||
| shuffled_indices = randperm(num_nodes) | ||
| shuffled_features = features[shuffled_indices, :] |
There was a problem hiding this comment.
this is shuffling feature dimensions, not nodes
|
Besides the issues that I commented, I think that this function should not be part of the library. It is not a common operation, it has used in that paper for probing the relevance of node features. This kind of operations should be done on the user side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues Issue #412
DGL function
Wasn't sure what to test in this one. Please let me know what other tests I should add since this is pretty straightforward.