-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added clique_number, independence_number #155
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, sorry for the late review
I've pushed an update that hopefully addresses these concerns. (I rebased to master - hopefully that doesn't make the diffs too messy.) After making a proper unit test for independent sets, I found I had to convert AbstractGraph to SimpleGraph in order to call complement. Performance shouldn't be an issue since this data copy is negligible in comparison to the cost of the maximal_cliques call. But I don't know if there is some other reason this would be problematic.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 97.28% 97.23% -0.06%
==========================================
Files 115 115
Lines 6789 6790 +1
==========================================
- Hits 6605 6602 -3
- Misses 184 188 +4 ☔ View full report in Codecov by Sentry. |
I would add a warning to the docstring pointing to the conversion, but otherwise I'd say it's okay |
These simple implementations use
maximal_cliques
as the computational engine. Perhaps there is a more efficient way, but it would be great to at least have these implemented.