-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bernoulli random graph #200
base: master
Are you sure you want to change the base?
Add Bernoulli random graph #200
Conversation
Co-authored-by: Emanuele Natale <natema@users.noreply.github.com>
Co-authored-by: Emanuele Natale <natema@users.noreply.github.com>
Co-authored-by: Emanuele Natale <natema@users.noreply.github.com>
Co-authored-by: Emanuele Natale <natema@users.noreply.github.com>
…ssi/Graphs.jl into bernoulli_random_graphs
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
==========================================
- Coverage 97.28% 97.24% -0.05%
==========================================
Files 115 114 -1
Lines 6789 6610 -179
==========================================
- Hits 6605 6428 -177
+ Misses 184 182 -2 |
I have just implemented the generator described in this paper , I have no knowledge of a directed case. |
g2_adj = adjacency_matrix(g2) | ||
@test g1_adj == g2_adj | ||
@test diag(g1_adj) == diag(g2_adj) == zeros(n) | ||
ρ = 0.5 # non isomorphism case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we do a probabilistic test on the correlation with ample error margins?
@aurorarossi is this good to go? |
Side note, this might be linked to #212 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but it still needs tests that the probability of an edge is approximately p
, and that the correlation between (nondiagonal?) adjacency matrices is approximately \rho
With this PR I add the Bernoulli random graph and the$\rho$ -correlated Bernoulli random graphs generators.